Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Config composition error with latest version of OmegaConf #1592

Closed
2 tasks done
odelalleau opened this issue Apr 30, 2021 · 0 comments · Fixed by #1593
Closed
2 tasks done

[Bug] Config composition error with latest version of OmegaConf #1592

odelalleau opened this issue Apr 30, 2021 · 0 comments · Fixed by #1593
Labels
bug Something isn't working

Comments

@odelalleau
Copy link
Collaborator

🐛 Bug

Description

When using OmegaConf at commit 2dd15f9 (first commit where this problem occurs), there are multiple Hydra tests failures, for instance:

pytest "tests/test_basic_launcher.py::TestBasicLauncher::test_sweep_1_job[basic-overrides0]"
(...)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = __INVALID__, value = None

    def validate_and_convert(self, value: Any) -> Any:
        """
        Validates input and converts to canonical form
        :param value: input value
        :return: converted value ("100" may be converted to 100 for example)
        """
        if value is None:
            if self._is_optional():
                return None
>           raise ValidationError("Non optional field cannot be assigned None")
E           hydra.errors.ConfigCompositionException

../omegaconf/omegaconf/nodes.py:55: ConfigCompositionException

Checklist

  • I checked on the latest version of Hydra
  • I created a minimal repro (See this for tips).

To reproduce

Use master branch of Hydra with OmegaConf's commit 2dd15f9

Additional context

This might actually be an OmegaConf bug (I'm not sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant