Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating pip package with changes in "Support Selector for IDMap #2848" #2988

Closed
ariaattar opened this issue Aug 6, 2023 · 6 comments
Closed
Labels

Comments

@ariaattar
Copy link

Hi, could you please update the python pip package with the changes in this PR #2848

Currently building from source in a Docker container but the container startup time is very slow!

Thank you.

@mlomeli1
Copy link
Contributor

mlomeli1 commented Aug 7, 2023

hi @ariaattar , we don't support installation via pip, please use conda.

@vaaliferov
Copy link

Hi! The latest version of faiss-cpu is 1.7.4 (for both pip and conda). And there are no changes from PR #2848 included. Any info on the next release timeline ? Are there any options available except building from source or waiting for the next release ?

@mlomeli1
Copy link
Contributor

mlomeli1 commented Aug 8, 2023

hi @vaaliferov , thanks for checking, I can get back to you about when we will publish the next release. In the meantime, you can just use the nightly package that is published daily and includes all commited changes (until the day before), use:

conda install -c pytorch/label/nightly faiss-cpu

@ariaattar

This comment was marked as resolved.

@ariaattar ariaattar reopened this Aug 11, 2023
@ariaattar

This comment was marked as resolved.

@mlomeli1
Copy link
Contributor

mlomeli1 commented Aug 11, 2023

@ariaattar why would you need to call faiss.swigfaiss in the first place? Can you try this instead:

if isinstance(faiss_index, faiss.IndexIDMap)

@mlomeli1 mlomeli1 closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants