Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when installing new dependencies #818

Closed
Etesam913 opened this issue Jul 11, 2022 · 1 comment · Fixed by #779
Closed

Errors when installing new dependencies #818

Etesam913 opened this issue Jul 11, 2022 · 1 comment · Fixed by #779
Assignees

Comments

@Etesam913
Copy link
Contributor

Etesam913 commented Jul 11, 2022

Overview

Adding a new dependency into requirements.txt causes errors to occur in the github actions workflow.

For example,
When I added the rich dependency to the requirements.txt file I got this output for the test:
https://github.com/facebookresearch/Mephisto/runs/7237323897?check_suite_focus=true

The issue is not exclusive to rich as I also got this error when trying to add the detoxify dependency.

@JackUrb
Copy link
Contributor

JackUrb commented Jul 11, 2022

For some context, we moved away from poetry due to python-poetry/poetry#34 causing issues with setup.py develop and other editable installs, which we needed to be able to do local development of tasks. This has been resolved as of Poetry 1.2, and as such the solution is to upgrade to there and then remove requirements.txt entirely and work from pyproject.toml instead. Will jump into this next week. In the meantime, feel free to skip the dependencies temporarily.

This is tied to #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants