Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Install packages and modules for format #11649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Install packages and modules for format #11649

wants to merge 1 commit into from

Conversation

acvictor
Copy link
Contributor

@acvictor acvictor commented Nov 25, 2024 •
edited
Loading

Install regex, cmake-format and clang-format.

make format-fix on a fresh Ubuntu installation returns

scripts/check.py format main --fix
Traceback (most recent call last):
  File "/home/av/src/Velox/scripts/check.py", line 20, in <module>
    import regex
ModuleNotFoundError: No module named 'regex'
make: *** [Makefile:172: format-fix] Error 1
/bin/sh: 1: cmake-format: not found
error: cannot find executable "clang-format"

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d816f20
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67444f541d0f0900083cc41a

@acvictor acvictor changed the title Install packages and modules for format build: Install packages and modules for format Nov 25, 2024
@acvictor acvictor marked this pull request as ready for review November 25, 2024 16:48
assignUser
assignUser reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you make use of venv as the makefile uses it? For some reason we have code for this in the macos script but neither ubuntu nor centos: https://github.com/facebookincubator/velox/blob/main/scripts/setup-macos.sh#L83-L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser left review comments

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acvictor @assignUser @facebook-github-bot