Iceberg row group fix new #10505
Closed
Iceberg row group fix new #10505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to create base data files and delete fiels with un-aligned Rowgroup boundaries. It also added several new test cases and improved some variable and function namings.
When the base data file and positional delete files contains multiple unaligned RowGroups, some of the bits at the end of IcebergSplitReader::deleteBitmap_ could be mistakenly skipped, causing wrong result. This commit fixes it by introducing an offset into this deleteBitmap_ and shift the unused bits to the beginning for each batch.
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
When a base file batch doesn't have matching delete positions, the delete bitmap size was set incorrectly. For such a batch, the delete bitmap size should be set as 0. Co-authored-by: Ying Su <[email protected]>
yingsu00
force-pushed
the
icebergRowGroupFixNew
branch
from
1f44741
to
832348e
Compare
Yuhta
approved these changes
Jul 19, 2024
Yuhta
added
the
ready-to-merge
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jul 21, 2024
|
@kevinwilfong merged this pull request in 7089078. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
1.
Fixes #9856
When the base data file and positional delete files contains multiple
unaligned RowGroups, some of the bits at the end of
IcebergSplitReader::deleteBitmap_ could be mistakenly skipped, causing
wrong result. This commit fixes it by introducing an offset into this
deleteBitmap_ and shift the unused bits to the beginning for each batch.
When a base file batch doesn't have matching delete positions, the delete
bitmap size was set incorrectly. For such a batch, the delete bitmap size should
be set as 0.