Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwio/common/compression/Compression.cpp DWIO_ENSURE_LE check output NOT as expected #11657

Open
zuyu opened this issue Nov 26, 2024 · 1 comment
Open

dwio/common/compression/Compression.cpp DWIO_ENSURE_LE check output NOT as expected #11657

zuyu opened this issue Nov 26, 2024 · 1 comment
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@zuyu
Copy link
Contributor

zuyu commented Nov 26, 2024 •
edited
Loading

Bug description

velox/velox/dwio/common/compression/Compression.cpp

Lines 290 to 297 in f33b40d

DWIO_ENSURE_LE(
compressedBlockSize,
compressedSize,
"{} decompression failed, compressedBlockSize is greater than compressedSize, "
"compressedBlockSize: {}, compressedSize: {}",
kind_,
compressedBlockSize,
compressedSize);

[Expected behavior]
Reason: [Range Constraint Violation : 32>=2227206908] : LZ4 decompression failed, remainingOutputSize is less than decompressedBlockSize, remainingOutputSize: 32, decompressedBlockSize: 2227206908

[actual behavior]
Reason: [Range Constraint Violation : 32>=2227206908] : {} decompression failed, remainingOutputSize is less than decompressedBlockSize, remainingOutputSize: {}, decompressedBlockSize: {}5322227206908
@zuyu zuyu added bug Something isn't working triage Newly created issue that needs attention. labels Nov 26, 2024
@zuyu zuyu changed the title dwio/common/compression DWIO_ENSURE_LE check output NOT as expected dwio/common/compression/Compression.cpp DWIO_ENSURE_LE check output NOT as expected Nov 26, 2024
@yingsu00
Copy link
Collaborator

cc @nmahadevuni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuyu @yingsu00