Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor TYPO in ztest build/test process #2768

Closed
stephan57160 opened this issue Sep 7, 2021 · 2 comments
Closed

Minor TYPO in ztest build/test process #2768

stephan57160 opened this issue Sep 7, 2021 · 2 comments

Comments

@stephan57160
Copy link

stephan57160 commented Sep 7, 2021

Describe the bug
Detected, when rebuilding from scratch with RPMBUILD on a CentOS Box :
Also consdier playing around with searchLog and hashLog

Appears a few times during the build/testing process.

Typo present in the sources:

[stephan@pc-stephan:zstd]$ find . -type f | xargs grep consdier
./programs/fileio.c:        DISPLAYLEVEL(1, "Also consdier playing around with searchLog and hashLog\n");
[stephan@pc-stephan:zstd]$ 

To Reproduce

  • git clone ...
  • cd zstd
  • make all pzstd tests tests_zstd 2>1& | grep consdier

Expected behavior
Should be "consider", not "consdier".

Screenshots and charts

[Optimal parser notes] Consider the following to improve patch size at the cost of speed:
- Use --single-thread mode in the zstd cli
- Set a larger targetLength (eg. --zstd=targetLength=4096)
- Set a larger chainLog (eg. --zstd=chainLog=29)
Also consdier playing around with searchLog and hashLog
     ^^^^^^^^

...

===> alternate syntax: patch-from origin
[Optimal parser notes] Consider the following to improve patch size at the cost of speed:
- Use --single-thread mode in the zstd cli
- Set a larger targetLength (eg. --zstd=targetLength=4096)
- Set a larger chainLog (eg. --zstd=chainLog=29)
Also consdier playing around with searchLog and hashLog
     ^^^^^^^^

...

zstd: error 42 : Using --patch-from with stdin requires --stream-size 
[Optimal parser notes] Consider the following to improve patch size at the cost of speed:
- Use --single-thread mode in the zstd cli
- Set a larger targetLength (eg. --zstd=targetLength=4096)
- Set a larger chainLog (eg. --zstd=chainLog=29)
Also consdier playing around with searchLog and hashLog
     ^^^^^^^^

...

Desktop (please complete the following information):

  • OS: NA
  • Version : NA
  • Compiler : NA
  • Flags : NA
  • Other relevant hardware specs : NA
  • Build system : Makefile

Additional context
Add any other context about the problem here.

@senhuang42
Copy link
Contributor

senhuang42 commented Sep 7, 2021

Thanks for pointing this out, should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants