Support custom implementations of Trace LDE #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grjte
force-pushed
the
grjte-custom-lde
branch
6 times, most recently
from
ee5baa5
to
01d9338
Compare
irakliyk
requested changes
Jul 8, 2023
There was a problem hiding this comment.
Looks great! Thank you! This is basically how I thought about this as well. I left a few comments inline. Most of them are pretty minor, except for the last comment which is about potentially adding a new() constructor to TraceLde and using it instead of Prover::new_trace_lde().
Regarding the tests: I think it would be great to have unit tests on DefaultTraceLde - so, I'd prefer if the removed tests were moved there. Looking at them, they may actually be a bit simpler now as it doesn't seem like we need to instantiate Air to test these behavior on DefaultTraceLde.
grjte
force-pushed
the
grjte-custom-lde
branch
3 times, most recently
from
2373566
to
24a1399
Compare
irakliyk
approved these changes
Jul 23, 2023
|
Oh - one other thing: we should add an entry to the changelog file for this. |
irakliyk
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #180. It's not quite ready for merge, but I'd like to get feedback on the approach
TraceLdestruct to a traitTraceLde