Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl clean --all ., doesn't. #564

Closed
steveluscher opened this issue Mar 14, 2023 · 4 comments
Closed

sl clean --all ., doesn't. #564

steveluscher opened this issue Mar 14, 2023 · 4 comments

Comments

@steveluscher
Copy link
Contributor

steveluscher commented Mar 14, 2023

Despite this claim:

> sl githelp -- git clean -dfx .
sl clean --all .

Running sl clean --all . doesn't remove untracked-and-ignored stuff like my node_modules/ folder.


Sapling 0.2.20230228-144002-h9440b05e

@steveluscher
Copy link
Contributor Author

steveluscher commented Mar 14, 2023

I see. It just doesn't remove empty dirs. OK, my feedback is that githelp should return this:

> sl githelp -- git clean -dfx .
sl clean --all --dirs .

…or that --all should include --dirs so that the behavior matches git.

@vegerot
Copy link
Contributor

vegerot commented Mar 20, 2023

Good idea. Will you submit a PR for this?

@steveluscher
Copy link
Contributor Author

steveluscher commented Mar 20, 2023

Which PR would you like @vegerot? The one that updates githelp's advice, or the one that changes the behaviour of --all?

@vegerot
Copy link
Contributor

vegerot commented Mar 21, 2023

the githelp one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants