Set options.num_levels in db_stress_test_base #10732
Conversation
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Please confirm CI-like commands pass. The comment after the last PR landed (#6818 (comment)) suggested it wouldn't.
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
Good call - I now run with CI like commands and initiated some jobs. Both seem fine so far. However, I think destroy_db_initially=1 is still a legit suggestion so I aded it here. Will run another overnight job to stress test the updated version before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Please confirm CI-like commands pass. The comment after the last PR landed (#6818 (comment)) suggested it wouldn't.
Good call - I now run with CI like commands and initiated some jobs. Both seem fine so far. However, I think destroy_db_initially=1 is still a legit suggestion so I aded it here. Will run another overnight job to stress test the updated version before landing.
Yeah it probably already worked considering the DB dir is completely removed between runs. I just hadn't checked. Thanks for making sure it works.
hx235
force-pushed
the
num_levels_in_stress
branch
from
20f805a to
f56d841
Compare
|
@hx235 has updated the pull request. You must reimport the pull request before landing. |
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…#10743) Summary: **Context:** #10732 (review) Pull Request resolved: #10743 Test Plan: - Locally run `python3 ./tools/db_crashtest.py whitebox --simple -max_key=1000000 -value_size_mult=33 -write_buffer_size=524288 -target_file_size_base=524288 -max_bytes_for_level_base=2097152 --duration=120 --interval=10 --ops_per_thread=1000 --random_kill_odd=887` - CI jobs testing Reviewed By: ajkr Differential Revision: D39838733 Pulled By: ajkr fbshipit-source-id: 9e819b66b0293dfc7a31a908a9d42c6baca4aeaa
An add-on to #6818 to complete adding single-level universal compaction to stress/crash testing.
Test:
python3 ./tools/db_crashtest.py whitebox --simple --compaction_style=1 --num_levels=1 -max_key=1000000 -value_size_mult=33 -write_buffer_size=524288 -target_file_size_base=524288 -max_bytes_for_level_base=2097152 --duration=120 --interval=10 --ops_per_thread=1000 --random_kill_odd=887