Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Comparison #34

Closed
mmazaheri opened this issue Dec 13, 2013 · 4 comments
Closed

Redis Comparison #34

mmazaheri opened this issue Dec 13, 2013 · 4 comments

Comments

@mmazaheri
Copy link

Hi,
I have general question but dont know wher to ask this:
How is RocksDB compared with Redis?

@dhruba
Copy link
Contributor

dhruba commented Dec 13, 2013

I have not run any benchmarks comparing the two. If you do run any benchmarks, can you pl share it with us?

@mmazaheri
Copy link
Author

I simply asking about functionality and their support and reliability from a developer perspective.

@dhruba
Copy link
Contributor

dhruba commented May 27, 2014

I have not run benchmarks on redis, so I cannot comment on its reliability. But RocksDB is highly reliable and is guaranteed to not have any "silent data loss".

@dhruba dhruba closed this as completed May 27, 2014
@mmazaheri
Copy link
Author

@dhruba Thanks a lot.

DorianZheng pushed a commit to DorianZheng/rocksdb that referenced this issue Aug 31, 2018
* titandb: support create/drop column families

* titandb: add TitanCFOptions in Blobstorage
DorianZheng pushed a commit to DorianZheng/rocksdb that referenced this issue Sep 5, 2018
* titandb: support create/drop column families

* titandb: add TitanCFOptions in Blobstorage
spetrunia pushed a commit to spetrunia/rocksdb that referenced this issue Jun 19, 2019
Fixed Kinesis-based WAL storing test
acelyc111 pushed a commit to pegasus-kv/rocksdb that referenced this issue Jul 12, 2023
…ok#34)

Summary:
PR facebook#5908 added `flush_jobs_info_` to `FlushJob` to make sure
`OnFlushCompleted()` is called after committing flush results to
MANIFEST. However, `flush_jobs_info_` is not updated in atomic
flush, causing `NotifyOnFlushCompleted()` to skip `OnFlushCompleted()`.

This PR fixes this, in a similar way to facebook#5908 that handles regular flush.

Pull Request resolved: facebook#8585

Test Plan: make check

Reviewed By: jay-zhuang

Differential Revision: D29913720

Pulled By: riversand963

fbshipit-source-id: 4ff023c98372fa2c93188d4a5c8a4e9ffa0f4dda

Co-authored-by: Yanqin Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants