unstable_batchedUpdates undefined in React Native

[amccloud]

I think RelayContainer depends on React.unstable_batchedUpdates which doesn't appear to be available under react-native. Instead it is React.addons.batchedUpdated.

[josephsavona]

@zpao What is the best approach here?

[zpao]

This ties into the work that needs to be done to get react native all on board with react 0.14 and no longer providing their own override. (eg, you would do require('react') to create classes, the same way you do on web - that would be the isomorphic react, then require('react-native') gives you something else, like the renderer a la require('react-dom')).

cc @spicyj @sebmarkbage who have been working on this.

Not sure how far out that is, but perhaps React Native can just add unstable_batchedUpdates to their React overrride.

[sophiebits]

Yes, the react-native package should expose that helper.

[amccloud]

@zpao Gotcha. Explains why I had to alias react to react-native to use relay.

[timkrins]

Ran into this issue when working through the react-treasurehunt example on Windows.

I don't have a deep enough understanding to figure out why unstable_batchedUpdates is undefined, but I modifed injectBatchingStrategy in GraphQLStoreChangeEmitter.js to get the example to work properly.

injectBatchingStrategy: function injectBatchingStrategy(batchStrategy) {
  if(typeof batchStrategy != 'undefined' )
  {
    batchUpdate = batchStrategy;
  }
},

[timkrins]

Ah, my particular issue is fixed in commit 2d82240. Note, this was unrelated to React Native.

[sophiebits]

On React Native you'll temporarily need to add a file called ReactDOM.js:

/**
 * @providesModule ReactDOM
 */

'use strict';

var ReactUpdates = require('ReactUpdates');

// Temporary shim required for Relay.
var ReactDOM = {
  unstable_batchedUpdates: ReactUpdates.batchedUpdates,
};

module.exports = ReactDOM;

but I was under the impression that the open-source Relay package has a couple other problems before it can be used directly in React Native…

[amccloud]

@spicyj Very few. This was one of the main issues. I am successfully using relay with react-native. I use webpack so I aliased react to react-native. I also had to include https://github.com/johanneslumpe/react-native-browser-polyfill

[sophiebits]

I'm not sure why you would need a self global…

[steveluscher]

It looks like the original issue is fixed. Feel free to reopen or file a new task if there's more to be done here (other than that covered by #26).