From 5e3c7b6d4f41461a1a6a59d3373d519ad9a0856d Mon Sep 17 00:00:00 2001
From: Konstantin Nesterov <wasd171@gmail.com>
Date: Wed, 20 Apr 2022 10:15:08 -0700
Subject: [PATCH] Build linux arm64 (#3882)

Summary:
Following discussions in https://github.com/facebook/relay/issues/3799 this PR adds support for a Linux ARM64 target for `relay-compiler`

Pull Request resolved: https://github.com/facebook/relay/pull/3882

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

**Static Docs Preview: relay**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D35760366/V2/relay/)|

|**Modified Pages**|

Reviewed By: josephsavona

Differential Revision: D35760366

Pulled By: alunyov

fbshipit-source-id: 4e79ce2ccbe91a70f2d91d80667fd6960210c7f1
---
 .github/workflows/ci.yml         | 28 ++++++++++++++++++++++++----
 packages/relay-compiler/index.js |  2 ++
 vscode-extension/src/utils.ts    |  2 ++
 3 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0814fe97c987a..3f9ba2a8059a6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -108,6 +108,12 @@ jobs:
             artifact-name: relay-bin-linux-x64
             packages: musl-tools
             features: vendored
+          - target: aarch64-unknown-linux-musl
+            os: ubuntu-latest
+            build-name: relay
+            artifact-name: relay-bin-linux-arm64
+            features: vendored
+            cross: true
           - target: x86_64-apple-darwin
             os: macos-latest
             build-name: relay
@@ -144,11 +150,19 @@ jobs:
       - name: Install packages
         if: matrix.target.os == 'ubuntu-latest' && matrix.target.packages
         run: sudo apt install ${{ matrix.target.packages }} -y
-      - uses: actions-rs/cargo@v1
+      - name: Install cross
+        if: matrix.target.cross
+        uses: actions-rs/cargo@v1
         with:
-          command: build
-          # add --locked back when we have a better way to ensure it's up to date
-          args: --manifest-path=compiler/Cargo.toml --release --target ${{ matrix.target.target }} ${{ matrix.target.features && '--features' }} ${{ matrix.target.features }}
+          command: install
+          args: cross
+      # Current published version of cross only works correctly if run from compiler directory
+      # See related issue https://github.com/cross-rs/cross/issues/615
+      # actions-rs/cargo@v1 does not support this option https://github.com/actions-rs/cargo/pull/59
+      # Either we need to install cross from git or manually run cargo / cross instead of using action
+      - name: Build project
+        working-directory: compiler
+        run: ${{ matrix.target.cross && 'cross' || 'cargo' }} build --release --target ${{ matrix.target.target }} ${{ matrix.target.features && '--features' }} ${{ matrix.target.features }}
       - uses: actions/upload-artifact@v2
         with:
           name: ${{ matrix.target.artifact-name }}
@@ -173,6 +187,11 @@ jobs:
         with:
           name: relay-bin-linux-x64
           path: artifacts/linux-x64
+      - name: Download artifact relay-bin-linux-arm64
+        uses: actions/download-artifact@v2
+        with:
+          name: relay-bin-linux-arm64
+          path: artifacts/linux-arm64
       - name: Download artifact relay-bin-macos-x64
         uses: actions/download-artifact@v2
         with:
@@ -192,6 +211,7 @@ jobs:
         working-directory: artifacts
         run: |
           chmod +x linux-x64/relay
+          chmod +x linux-arm64/relay
           chmod +x macos-x64/relay
           chmod +x macos-arm64/relay
 
diff --git a/packages/relay-compiler/index.js b/packages/relay-compiler/index.js
index 366588fff8acb..4636667ef3797 100644
--- a/packages/relay-compiler/index.js
+++ b/packages/relay-compiler/index.js
@@ -22,6 +22,8 @@ if (process.platform === 'darwin' && process.arch === 'x64') {
   binary = path.join(__dirname, 'macos-arm64', 'relay');
 } else if (process.platform === 'linux' && process.arch === 'x64') {
   binary = path.join(__dirname, 'linux-x64', 'relay');
+} else if (process.platform === 'linux' && process.arch === 'arm64') {
+  binary = path.join(__dirname, 'linux-arm64', 'relay');
 } else if (process.platform === 'win32' && process.arch === 'x64') {
   binary = path.join(__dirname, 'win-x64', 'relay.exe');
 } else {
diff --git a/vscode-extension/src/utils.ts b/vscode-extension/src/utils.ts
index cc27111da5a35..4c92549eb447e 100644
--- a/vscode-extension/src/utils.ts
+++ b/vscode-extension/src/utils.ts
@@ -26,6 +26,8 @@ function getBinaryPathRelativeToPackageJson() {
     binaryPathRelativeToPackageJson = path.join('macos-arm64', 'relay');
   } else if (process.platform === 'linux' && process.arch === 'x64') {
     binaryPathRelativeToPackageJson = path.join('linux-x64', 'relay');
+  } else if (process.platform === 'linux' && process.arch === 'arm64') {
+    binaryPathRelativeToPackageJson = path.join('linux-arm64', 'relay');
   } else if (process.platform === 'win32' && process.arch === 'x64') {
     binaryPathRelativeToPackageJson = path.join('win-x64', 'relay.exe');
   } else {