Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse M.[] #2043

Merged
merged 4 commits into from
Jul 2, 2018
Merged

Parse M.[] #2043

merged 4 commits into from
Jul 2, 2018

Conversation

anmonteiro
Copy link
Member

fixes #2028

@IwanKaramazow
Copy link
Contributor

What happens in a jsx context?

IwanKaramazow
IwanKaramazow reviewed Jul 2, 2018
View reviewed changes
formatTest/unit_tests/expected_output/modules.re Outdated
@@ -608,3 +608,6 @@ let foo =
module Y: Y_t with type t = a,
module Z: Z_t with type t = a,
) => X.a;

/* https://github.com/facebook/reason/issues/2028 */
M.([]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the parens?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I'll investigate if there are conflicts.

@anmonteiro
Copy link
Member Author

Thanks for the review. I added test cases for JSX context + tweaked the printer to print without parens.

@IwanKaramazow
Copy link
Contributor

Thanks for the quick PR! Looks fine by me.
@chenglou ready to merge.

@chenglou
Copy link
Member

chenglou commented Jul 2, 2018

Thanks

@chenglou chenglou merged commit a6bd696 into reasonml:master Jul 2, 2018
@anmonteiro anmonteiro deleted the gh-2028 branch July 2, 2018 20:48
@anmonteiro anmonteiro mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M.[] fails to parse
4 participants
@anmonteiro @IwanKaramazow @chenglou @facebook-github-bot