Remove extra space before return type declaration in function definition #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenglou
reviewed
May 28, 2018
| (argsList@[formatJustTheTypeConstraint typeLayout], e) | ||
| ([makeList | ||
| ~break:IfNeed | ||
| ~indent:(settings.space * settings.indentWrappedPatternArgs) |
There was a problem hiding this comment.
oh man, settings.space? Have we been using this consistently? cc @IwanKaramazow
There was a problem hiding this comment.
I used the same setting that wrapCurriedFunctionBinding employs, given that's where it all trickled down before.
There was a problem hiding this comment.
settings.space exists and the space setting is used only in function bindings I think. It's pretty obscure, since it defaults to the default 2 here.
|
Looks good. Thanks! |
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
May 28, 2018
This is a follow-up to reasonml#1966, this time removing the extra space before type definitions for external declarations.
anmonteiro
added a commit
to anmonteiro/reason
that referenced
this pull request
May 28, 2018
This is a follow-up to reasonml#1966, this time removing the extra space before type definitions for external declarations.
chenglou
pushed a commit
that referenced
this pull request
May 28, 2018
* Remove extra space before external type definition This is a follow-up to #1966, this time removing the extra space before type definitions for external declarations. * remove useless directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1628