Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punned arguments now ignore those with attributes #1955

Merged
merged 1 commit into from
May 26, 2018
Merged

Punned arguments now ignore those with attributes #1955

merged 1 commit into from
May 26, 2018

Conversation

vishnugopal
Copy link
Contributor

Punned arguments that have attributes are now ignored by refmt when formatting. This solves a parse error after refmt was run. This is intended to fix #1909

This is my first pull request, please be gentle!

Punned arguments that have attributes are now ignored by refmt
when formatting. This solves a parse error after refmt was run.
Fixes #1909
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@vishnugopal
Copy link
Contributor Author

I have signed the CLA now!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@chenglou
Copy link
Member

Hah, nice catch! Thanks.

@chenglou chenglou merged commit 1e578fc into reasonml:master May 26, 2018
@vishnugopal vishnugopal deleted the fix-issue-1909 branch May 28, 2018 04:29
@jordwalke
Copy link
Member

This is really good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting of attributes on named arguments (punned) causes parse error.
4 participants