parser/pprint_ast: force parentheses around switch (...)/try (...) #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was fast. Thanks! Is it possible to only do the printing change for now? This way after folks all refmt their files we can release the parser change, which wouldn't break (many) things |
|
How does this change the parsing of switching on tuples? |
|
It doesn't change: |
chenglou
added a commit
that referenced
this pull request
Jan 6, 2018
See #1720 (comment) This way of printing with parens while parsing both lets userland gradually use the enforced parens syntax without breaking their app (especially, and mainly, if they have third-party dependencies). We'll re-revert this patch in the future.
chenglou
added a commit
that referenced
this pull request
Jan 6, 2018
See #1720 (comment) This way of printing with parens while parsing both lets userland gradually use the enforced parens syntax without breaking their app (especially, and mainly, if they have third-party dependencies). We'll re-revert this patch in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR force scrutinees in
switchandtryexpressions to be wrapped with parentheses:switch (a) { | None => ... }.