Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fax] Make react-markup publishable via scripts #30722

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 16, 2024

Summary

Publishable packages are hardcoded which was missed in #30690.

First published as 0.0.0-experimental-1eaccd82-20240816

How did you test this change?

$ scripts/release/prepare-release-from-ci.js --skipTests -r experimental --commit=fa6eab58541330349480690ef4e211520cc08d94
$ scripts/release/publish.js --tags experimental
✓ You are about the publish the following packages under the tag experimental:
[...]
react-markup 0.0.0-experimental-fa6eab58-20240815

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 4:39pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Aug 16, 2024
@react-sizebot
Copy link

Comparing: fa6eab5...7b2ee78

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ae16124

@eps1lon eps1lon merged commit 1eaccd8 into facebook:main Aug 16, 2024
185 checks passed
@eps1lon eps1lon deleted the fax/publishable branch August 16, 2024 19:08
@eps1lon
Copy link
Collaborator Author

eps1lon commented Aug 16, 2024

First published as 0.0.0-experimental-1eaccd82-20240816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants