Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools: Read context values from context dependencies #28467

Merged
merged 8 commits into from
Mar 20, 2024
Merged

DevTools: Read context values from context dependencies #28467

merged 8 commits into from
Mar 20, 2024

Commits on Mar 5, 2024

  1. DevTools: Read context values from context dependencies

    Sebastian Silbermann committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4a69a70 View commit details
    Browse the repository at this point in the history

  2. Make it explicit that reading from context directly is only supported… 

    … when not having access to the Fiber tree
    Sebastian Silbermann committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e9eaac1 View commit details
    Browse the repository at this point in the history

  3. Remove special context 

    Neither writing primitive stack cache nor  `ReactDebugTools.inspectHooks()` have
access to the fiber tree.
    Sebastian Silbermann committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2c0bdc8 View commit details
    Browse the repository at this point in the history

  4. if-else

    Sebastian Silbermann committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0775186 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Ensure backwards compatibility with older reconciler versions

    @eps1lon
    eps1lon committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0df1e46 View commit details
    Browse the repository at this point in the history

  2. No memoizedValue before React 18

    @eps1lon
    eps1lon committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2f5faa4 View commit details
    Browse the repository at this point in the history

  3. Keep old control flow

    @eps1lon
    eps1lon committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4c2a435 View commit details
    Browse the repository at this point in the history

  4. Not all versions of fiber.dependencies have `contextDependency.memo… 

    …izedValue`

I considered polyfilling `memoizedValue` but it seems safer to call this out when we read the context value.
And also to avoid deopts due to using expando properties on the ContextDependency type in old versions.
    @eps1lon
    eps1lon committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    088fb2c View commit details
    Browse the repository at this point in the history