DevTools imports #24163
Merged
DevTools imports #24163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
mondaychen
approved these changes
Mar 25, 2022
bvaughn
commented
Mar 25, 2022
| @@ -28,6 +28,7 @@ ignoreErrors([ | |||
| 'Warning: Legacy context API', | |||
| 'Warning: Unsafe lifecycle methods', | |||
| 'Warning: %s is deprecated in StrictMode.', // findDOMNode | |||
| 'Warning: ReactDOM.render is no longer supported in React 18', | |||
There was a problem hiding this comment.
It's okay to ignore this in the DevTools test harness. We intentionally use legacy render so that we can integration-test it. Once it's (eventually) removed, we'll remove it too in DevTools. (Or we'll add a legacy version of React to the test harness.)
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* Update DevTools imports: react-dom -> react-dom/client * Silence ReactDOM.render warning in DevTools test shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some of the "react-dom/client" import cleanup got missed when the entry point was changed, so I fixed them in this PR to avoid having the DevTools console spammed with deprecation warnings.