[Fizz/Flight] Don't start writing to the stream if it's already full #22726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 2b77ab2...8b6d828 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
devknoll
changed the title
|
I don't have context on this and Seb is out for a bit. Is this blocking you? |
2 tasks
|
ping @sebmarkbage |
sebmarkbage
approved these changes
Dec 9, 2021
| destination.cork(); | ||
| export function beginWriting(destination: Destination): boolean { | ||
| // Older versions of Node don't have this. | ||
| if (destination.writableNeedDrain !== true) { |
There was a problem hiding this comment.
How about writableLength >= writableHighWaterMark? It goes back a little further in terms of Node versions. That's what write() practically returns, and what is checked before needDrain is set to true. It's also how we implement that for web streams.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, React will always write something when flushing completed work, because it never checks if the stream is full until after writing. With this change, React will bail out early and continue buffering if we know we're still waiting for the stream to drain, so that we only write the most up-to-date data to the stream.
How did you test this change?
Existing tests pass. Could probably use a test to validate full behavior.