Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear performance marks after measuring #22345

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 17, 2021

Once we've measured an event duration, we no longer need the marks. This PR adds calls to clearMarks to remove them from the browser's performance entry buffer. (They'll still be in the exported profiling JSON which is what the scheduling profiler needs.)

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 17, 2021
@bvaughn bvaughn merged commit bc9bb87 into facebook:main Sep 17, 2021
@bvaughn bvaughn deleted the clearMarks branch September 17, 2021 14:46
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants