Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling profiler: UX tweaks #21971

Merged
merged 2 commits into from
Jul 27, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't show tooltips when mouse is down on an active view/surface/tool
Brian Vaughn committed Jul 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d70b5839af2541da1d3cfe3027585a18bda93ba9
Original file line number Diff line number Diff line change
@@ -507,7 +507,7 @@ function AutoSizedCanvas({data, height, width}: AutoSizedCanvasProps) {
);
}}
</ContextMenu>
{!isContextMenuShown && (
{!isContextMenuShown && !surfaceRef.current.hasActiveView() && (
<EventTooltip
data={data}
hoveredEvent={hoveredEvent}
Original file line number Diff line number Diff line change
@@ -62,6 +62,10 @@ export class Surface {
hoveredView: null,
};

hasActiveView(): boolean {
return this._viewRefs.activeView !== null;
}

setCanvas(canvas: HTMLCanvasElement, canvasSize: Size) {
this._context = getCanvasContext(
canvas,