Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error boundary in inspected elements panel #21531

Merged
merged 1 commit into from
May 19, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 19, 2021

Show more info about the error as well as the option to report it to GitHub.

The previous error boundary was probably preventing users from reporting certain kinds of issues (like #21528).

Before

Error boundary before

After

Error boundary after

Show more info about the error as well as the option to report it to GitHub.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 19, 2021
@sizebot
Copy link

sizebot commented May 19, 2021

Comparing: 3f8f467...000deba

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB
facebook-www/ReactDOM-prod.modern.js = 394.46 kB 394.46 kB = 73.29 kB 73.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 000deba

@bvaughn bvaughn merged commit 99995c1 into facebook:master May 19, 2021
@bvaughn bvaughn deleted the devtools-error-boundary branch May 19, 2021 17:27
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Show more info about the error as well as the option to report it to GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants