-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel 7 #16297
Merged
Merged
Babel 7 #16297
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ecd1734
initial babel stuff
lunaruan ea8022d
blah
lunaruan 988d630
Merge branch 'master' of https://github.com/facebook/react into upgra…
lunaruan d73c6eb
deleted class transform
lunaruan aecac62
add plugin transform classes
lunaruan fc409b6
cleaned up babel config and code, fixed issue where extra functions w…
lunaruan c9c99fc
fixed ReactFreshBabelPlugin tests
lunaruan 1c233d6
update react fresh test
lunaruan 88eeb24
updated options for babel/plugin-proposal-class-properties to replica…
lunaruan df8856c
cleaned up code
lunaruan 79f3507
modified ReactFreshBabelPlugin and switched to using only babel plugins
lunaruan faa6e32
fixed jest config.source-persistent.js
lunaruan 4b02b0f
remove babel-jest
lunaruan 2e07a65
removed transform-react-display-name
lunaruan 348fae3
Merge branch 'master' of https://github.com/facebook/react into upgra…
lunaruan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
packages/react-refresh/src/__tests__/ReactFreshBabelPluginProd-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
let babel = require('@babel/core'); | ||
let {wrap} = require('jest-snapshot-serializer-raw'); | ||
let freshPlugin = require('react-refresh/babel'); | ||
|
||
function transform(input, options = {}) { | ||
return wrap( | ||
babel.transform(input, { | ||
babelrc: false, | ||
configFile: false, | ||
plugins: [ | ||
'@babel/syntax-jsx', | ||
'@babel/syntax-dynamic-import', | ||
freshPlugin, | ||
...(options.plugins || []), | ||
], | ||
}).code, | ||
); | ||
} | ||
|
||
describe('ReactFreshBabelPlugin Prod', () => { | ||
it('thorw error if environment is not development', () => { | ||
let error; | ||
try { | ||
transform(`function Hello() {}`); | ||
} catch (transformError) { | ||
error = transformError; | ||
} | ||
expect(error).toEqual( | ||
new Error( | ||
'[BABEL] unknown: React Refresh Babel transform should only be enabled ' + | ||
'in development environment. Instead, the environment is: "' + | ||
process.env.NODE_ENV + | ||
'". (While processing: "base$2")', | ||
), | ||
); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this one. Don't need it.