Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clear memoizedState on unmount of fiber to avoid memory leak" #14275

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 19, 2018

Reverts #14218

@trueadm trueadm merged commit 5926765 into master Nov 19, 2018
@sizebot
Copy link

sizebot commented Nov 19, 2018

ReactDOM: size: -0.2%, gzip: -0.1%

Details of bundled changes.

Comparing: 9b2fb24...9a91f12

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.1% 716.6 KB 716.22 KB 165.87 KB 165.78 KB UMD_DEV
react-dom.production.min.js -0.2% -0.1% 97.85 KB 97.66 KB 31.82 KB 31.8 KB UMD_PROD
react-dom.profiling.min.js -0.2% -0.0% 100.75 KB 100.56 KB 32.51 KB 32.5 KB UMD_PROFILING
react-dom.development.js -0.1% -0.1% 711.91 KB 711.53 KB 164.49 KB 164.4 KB NODE_DEV
react-dom.production.min.js -0.2% -0.1% 97.84 KB 97.65 KB 31.35 KB 31.31 KB NODE_PROD
react-dom.profiling.min.js -0.2% -0.1% 100.84 KB 100.65 KB 31.96 KB 31.93 KB NODE_PROFILING
ReactDOM-dev.js -0.1% -0.0% 733.1 KB 732.72 KB 165.62 KB 165.55 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.1% 310.04 KB 309.63 KB 57.1 KB 57.06 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.1% 316.91 KB 316.53 KB 58.51 KB 58.46 KB FB_WWW_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 496.99 KB 496.63 KB 109.69 KB 109.61 KB UMD_DEV
react-art.production.min.js -0.2% -0.2% 90.01 KB 89.83 KB 27.65 KB 27.61 KB UMD_PROD
react-art.development.js -0.1% -0.1% 428.79 KB 428.41 KB 92.66 KB 92.56 KB NODE_DEV
react-art.production.min.js -0.3% -0.2% 55 KB 54.81 KB 16.94 KB 16.9 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 435.82 KB 435.44 KB 91.56 KB 91.48 KB FB_WWW_DEV
ReactART-prod.js -0.2% -0.1% 183.82 KB 183.41 KB 31.39 KB 31.35 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.1% 560.93 KB 560.55 KB 122.25 KB 122.18 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.2% -0.1% 239.25 KB 238.84 KB 42.08 KB 42.04 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.2% -0.1% 245.18 KB 244.81 KB 43.44 KB 43.39 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.1% -0.1% 560.63 KB 560.25 KB 122.16 KB 122.08 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.2% -0.1% 224.69 KB 224.28 KB 39.01 KB 38.96 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.2% -0.1% 230.38 KB 230 KB 40.36 KB 40.31 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.1% -0.1% 551.25 KB 550.87 KB 119.77 KB 119.69 KB RN_FB_DEV
ReactFabric-prod.js -0.2% -0.1% 218.66 KB 218.27 KB 37.66 KB 37.63 KB RN_FB_PROD
ReactFabric-profiling.js -0.2% -0.1% 223.4 KB 223.05 KB 39.08 KB 39.04 KB RN_FB_PROFILING
ReactFabric-dev.js -0.1% -0.1% 551.28 KB 550.9 KB 119.79 KB 119.71 KB RN_OSS_DEV
ReactFabric-prod.js -0.2% -0.1% 218.69 KB 218.31 KB 37.68 KB 37.64 KB RN_OSS_PROD
ReactFabric-profiling.js -0.2% -0.1% 223.44 KB 223.09 KB 39.1 KB 39.05 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% -0.1% 441.45 KB 441.07 KB 95.35 KB 95.26 KB UMD_DEV
react-test-renderer.production.min.js -0.3% -0.2% 56.22 KB 56.03 KB 17.22 KB 17.19 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 436.67 KB 436.29 KB 94.2 KB 94.11 KB NODE_DEV
react-test-renderer.production.min.js -0.3% -0.1% 55.89 KB 55.7 KB 17.07 KB 17.05 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 443.8 KB 443.42 KB 93.37 KB 93.29 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.1% 426.63 KB 426.25 KB 91.17 KB 91.07 KB NODE_DEV
react-reconciler.production.min.js -0.3% -0.3% 56.13 KB 55.94 KB 16.82 KB 16.77 KB NODE_PROD
react-reconciler-persistent.development.js -0.1% -0.1% 425.08 KB 424.7 KB 90.53 KB 90.44 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.3% -0.3% 56.14 KB 55.95 KB 16.83 KB 16.78 KB NODE_PROD

Generated by 🚫 dangerJS

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@kassens kassens deleted the revert-14218-memory-leak-on-unmount branch November 29, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants