Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactAnimationGroup failing to re-add components/reverse animations. #649

Closed
Cartas opened this issue Dec 10, 2013 · 2 comments · Fixed by #642
Closed

ReactAnimationGroup failing to re-add components/reverse animations. #649

Cartas opened this issue Dec 10, 2013 · 2 comments · Fixed by #642

Comments

@Cartas
Copy link
Contributor

Cartas commented Dec 10, 2013

Please see: http://jsfiddle.net/LvkNt/10/ and do the following:

  1. Click 'Toggle' to make the list-item fade into view.
  2. Double-click/Spam-click the 'Toggle' button again to make the item fade-out of view.
  3. Click 'Toggle' again to try to make the component come back into view.

You'll see that the item doesn't come back! If you check the HTML, you can see that the list-item is still there, with the class name "example-leave example-leave-active".

I suspect that React should reverse the animation elegantly in the case of the same component being re-added in the render function during a leave transition.

@sophiebits
Copy link
Collaborator

Thanks, I was going to point you to #642 but I see that you're the author of it!

@Cartas
Copy link
Contributor Author

Cartas commented Dec 10, 2013

Hehe, I thought perhaps it'd be best if I made a proper Issue (with JSFiddle example!) rather than just rudely posting Pull Requests! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants