Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldComponentUpdate vs componentShouldUpdate #6096

Closed
caub opened this issue Feb 23, 2016 · 3 comments
Closed

shouldComponentUpdate vs componentShouldUpdate #6096

caub opened this issue Feb 23, 2016 · 3 comments

Comments

@caub
Copy link

caub commented Feb 23, 2016

Why did you choose the former? the latter matches a bit better with componentDidMount, ...

@sher
Copy link

sher commented Feb 23, 2016

Because it is a question returning boolean?

@leoselig
Copy link
Contributor

this came up here once #5671 and is discussed here reactjs/react-future#40

@caub
Copy link
Author

caub commented Feb 23, 2016

ah ok sorry guys, good point tundrax

@caub caub closed this as completed Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants