Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReactDOM bug] Missing upgrade in test-utils #25469

Closed
spamshaker opened this issue Oct 12, 2022 · 2 comments
Closed

[ReactDOM bug] Missing upgrade in test-utils #25469

spamshaker opened this issue Oct 12, 2022 · 2 comments

Comments

@spamshaker
Copy link

According to documentation https://reactjs.org/docs/test-utils.html#renderintodocument, should be:

const domContainer = document.createElement('div');
ReactDOM.createRoot(domContainer).render(element);

but is ReactDOM.render

react/packages/react-dom/src/test-utils/ReactTestUtils.js

Line 137 in 2cf4352

return ReactDOM.render(element, div);

@spamshaker spamshaker changed the title [ReactDOM] Missing upgrade in test-utils [ReactDOM bug] Missing upgrade in test-utils Oct 12, 2022
@zabihhaqqani
Copy link

zabihhaqqani commented Oct 12, 2022 •
edited
Loading

Hi, I would like to work on this issue!

can you help me out

@eps1lon
Copy link
Collaborator

eps1lon commented Oct 16, 2022

Duplicate of #25446

@eps1lon eps1lon marked this as a duplicate of #25446 Oct 16, 2022
@eps1lon eps1lon closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spamshaker @eps1lon @zabihhaqqani