Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: React Dev Tools fail to show component updates with memoized components. #20696

Closed
lifeiscontent opened this issue Jan 30, 2021 · 4 comments · Fixed by #22008
Closed

Bug: React Dev Tools fail to show component updates with memoized components. #20696

lifeiscontent opened this issue Jan 30, 2021 · 4 comments · Fixed by #22008
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug

Comments

@lifeiscontent
Copy link

lifeiscontent commented Jan 30, 2021

React version: 17.0.1

Steps To Reproduce

  1. run the project: https://github.com/lifeiscontent/immutable-todo
  2. open react dev tools and set the highlight updates when components render option.
  3. add changes to the todos
  4. see no updates are displayed via React dev tools

Link to code example:

https://github.com/lifeiscontent/immutable-todo

The current behavior

currently, updates are only displayed if the react component is not memoized.

The expected behavior

all react components should show their updates regardless of memoization.

@lifeiscontent lifeiscontent added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Jan 30, 2021
@lifeiscontent
Copy link
Author

@gaearon any idea who I should ping to get some eyes on this?

@bvaughn
Copy link
Contributor

bvaughn commented Apr 1, 2021

No one needs to be pinged. We review GitHub issues as we have bandwidth. If you'd like to contribute a bug fix, those are welcome. 👍🏼

@lifeiscontent
Copy link
Author

lifeiscontent commented Apr 1, 2021

@bvaughn Sure, do you have an idea where I might look to investigate something like this? It would be my first time contributing to that code so it'd be greatly helpful if someone could point me in the general direction.

@mokimo
Copy link

mokimo commented Apr 1, 2021

@lifeiscontent a start would be reading this https://reactjs.org/docs/how-to-contribute.html

Then you can read through the readme's of the react dev tools packages to get an idea of to start and debug the dev tools locally.

Haven't submitted anything myself, but that's how I'd start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants