Bug: react-hooks/exhaustive-deps reports a TypeScript type via typeof as a dependency

[RebeccaStevens]

react-hooks/exhaustive-deps reports a missing dependency when a variable is used purely for it's type.

Once the typescript code has been transpiled, that variable will no longer be referenced in that part of the code and thus it's not a dependency.

React version: [email protected]
Eslint Plugin version: [email protected]

Steps To Reproduce

1. Have some typed variable declared in the component.
2. Within a hook callback, refer to that variable's type via typeof x

Link to code example: https://codesandbox.io/s/late-sun-rpws4?file=/src/App.tsx

The current behavior

An eslint error such as the following occurs:

react-hooks/exhaustive-deps - "React Hook useEffect has a missing dependency: ..."

The expected behavior

No error should occur.

[rickhanlonii]

Oh nice find @RebeccaStevens, confirmed. Any interest in working on a PR?

[rickhanlonii]

Actually this may be a dupe of #18828.

And the related PR #19316 may fix it already, will check with the PR author.

[RebeccaStevens]

Looks, like it is. Sorry for the dupe.

[rickhanlonii]

No worry! Let's keep this open in case it's slightly different and to make sure we add a test case for this specific example 👍

[gaearon]

@delca85 fixed this in #19316. If you find other similar issues, please report them too! Thanks.

[email protected] should have the fix.