Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rollup #13701

Closed
mmarkelov opened this issue Sep 20, 2018 · 4 comments
Closed

Upgrade Rollup #13701

mmarkelov opened this issue Sep 20, 2018 · 4 comments
Labels
Component: Build Infrastructure Resolution: Stale Automatically closed due to inactivity

Comments

@mmarkelov
Copy link
Contributor

Working on upgrading rollup - some test builds show decreasing in size of bundles.
But also there are some problems with it:

  1. The legacy option is now deprecated, so is it critical for building react ?
    I checked this issue - and it tells that it's totally fine.
  2. There are couples circular dependency warnings with ReactFiberScheduler.js and also some default' is not exported warnings

You also can check my branch
Maybe you can help me with it

So what do you think about this? Does that make sense?

@TrySound
Copy link
Contributor

WIP in #13356 #13321

@mmarkelov
Copy link
Contributor Author

@TrySound, just didn’t see these prs ( My mistake. If you need some help about this I’ll be happy to help you

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Infrastructure Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

4 participants
@gaearon @TrySound @mmarkelov and others