-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Babel 7 #12548
Comments
babel-jest latest version still doesn't support babel v7. The tests might face an issue after I update Probably should do a beta release with babel-7 support in babel-jest |
Did you try the instructions here on how to use Jest with Babel 7? https://facebook.github.io/jest/docs/en/getting-started.html#using-babel
|
Babel Jest definitely supports Babel 7, we're using them together in CRA |
Not sure about
|
|
@reznord may I take this? |
Is anyone working on this still ? If not I would give it a try. Thanks :) |
I also want to help. @dantesolis can we both work on it together? If no one else is working on it. |
@armujahid yes sure, we can work on this together. :) |
@dantesolis I have started working on it. https://github.com/armujahid/react/tree/babel7 but its not complete yet. |
@armujahid, wow you move fast! I will start working on it today or tomorrow, how should we tackle it so we don’t work on the same thing at the same time? Basically what have you not done so I can table it today? :) |
@dantesolis I have added you as collaborator to my repository. You can see my changes in babel7 branch
Issues: |
Let me check on that. |
@armujahid I'll be working on this then today and tomorrow. |
@acdlite I just finished work on it in my Babel 7 branch. It was huge challenge. I passed all tests, but I just don't sure if I can make PR for it. |
@mmarkelov That’s great! Please open the PR! |
@acdlite Just can't figure out what's wrong with last step - |
@mmarkelov is there any updates on this? I'd like to help if you want |
@loryman I just got some tests fails - it was a big challenge. Of cause you can help. It will be nice. You can check my actual branch also I can add you as collaborator. |
Thank you! I cloned your branch and i've started working on it. I can open a PR to your repo with all the changes |
Hey guys! @loryman @mmarkelov still working on this one? |
@loryman @mmarkelov are you successful in working on this problem? |
Sorry, I haven't been able to work on this. Anyway, I think we have to wait for #15037 to get merged, then I'll try to continue from that |
Would it be better to upgrade each package, one by one, to Babel 7 in separate PRs? |
Hi, is there any small task, i would like to do |
Thanks everyone for your work on this! @mmarkelov @armujahid Added you two as coauthors to the PR. |
Not all packages have been upgraded to babel 7 (for example, react-art), so should we reopen this issue? |
Babel 7 is still in beta, but presumably it will be released soon. We should get a head start on upgrading. Perhaps it's stable enough for us to upgrade even before the final release.
One benefit is we could use JSX fragment syntax in tests. Yay!
@reznord has volunteered to pick this up.
The text was updated successfully, but these errors were encountered: