-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context update doesn't fully propagate in some cases #12246
Labels
Comments
3 tasks
@gaearon I solved this bug for particular task by changing the 'key' props for each EmojiResultRow item from title to index. This is bad decision. But the bug maybe in Provider reconciliation. class EmojiResults extends PureComponent {
render() {
return (
<div className="component-emoji-results">
{this.props.emojiData.map((emojiData, index) => (
<EmojiResultRow
key={index}
symbol={emojiData.symbol}
title={emojiData.title}
/>
))}
</div>
);
}
} |
@gaearon @AlexanderKositsyn I know what the bug is. On my todo list :) |
Fixed by #12478 |
@acdlite Wrong link? |
Oops, sorry. Meant #12254. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think there may be a bug in context in the latest alpha. When some updates are scheduled in the commit phase, it doesn't seem to propagate.
Enter "mon". Erase it. Click on "dark mode".
Expected: all children update. Actual: some children don't update.
This only seems to happen with this indirection.
The text was updated successfully, but these errors were encountered: