-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM Test Fixtures: Add caveats for IE9 range inputs (and other unsupported things) #11131
Comments
@sophiebits mentioned in #9301 that IE9 was maybe, probably OK not to support. If we can get confirmation on that, this would be a non-issue. |
yo it would be awesome to not support ie9 |
FWIW, all of this works in IE9. IE9 just doesn't have range inputs, so the range input test case doesn't test arrow keys. I just want to add a disclaimer in case someone comes to this page as a public site and gets confused and blames React. |
@nhunzaker should we do the same for unsupported browsers? Maybe we can add some browser detection logic and then render a message like:
And then we can reuse the detection logic for other browser-specific quirks like this. |
We could use something like bowser for browser detection. |
might be worth pulling in like modernizer and attaching |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you! |
It can be confusing to recall that the range input type is not supported in IE9, invalidating a few of our test cases. For example:
This test case verifies that changing a range slider with arrow keys works as expected, however it looks like a standard input in IE9. If we plan to make these test fixtures more public, I wonder if it would be worth adding some caveat language or marking a test as invalid for a certain browser.
Maybe this would be annoying, but I thought it might be nice to collect the opinion of others.
The text was updated successfully, but these errors were encountered: