Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4902282c25c5570c7b3f7b8fcd1c1bcb8120ad8a
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 447131a16badeac0af341afaf99ca6dc06c1f31f
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 16, 2025

  1. [ci] Better filtering for discord notifications

    We don't always consistently use "tags" in commit messages, so let's use the filepaths modified in the PR instead to determine which channel to send notifications to.
    poteto committed Jan 16, 2025

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    addaleax Anna Henningsen
    Copy the full SHA
    447131a View commit details
Showing with 48 additions and 35 deletions.
  1. +24 −0 .github/workflows/compiler_discord_notify.yml
  2. +24 −0 .github/workflows/runtime_discord_notify.yml
  3. +0 −35 .github/workflows/shared_discord_notify.yml
24 changes: 24 additions & 0 deletions .github/workflows/compiler_discord_notify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: (Compiler) Discord Notify

on:
pull_request_target:
types: [labeled]
paths:
- compiler/**
- .github/workflows/compiler_**.yml

jobs:
notify:
if: ${{ github.event.label.name == 'React Core Team' }}
runs-on: ubuntu-latest
steps:
- name: Discord Webhook Action
uses: tsickert/discord-webhook@v6.0.0
with:
webhook-url: ${{ secrets.COMPILER_DISCORD_WEBHOOK_URL }}
embed-author-name: ${{ github.event.pull_request.user.login }}
embed-author-url: ${{ github.event.pull_request.user.html_url }}
embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }}
embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}'
embed-description: ${{ github.event.pull_request.body }}
embed-url: ${{ github.event.pull_request.html_url }}
24 changes: 24 additions & 0 deletions .github/workflows/runtime_discord_notify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: (Runtime) Discord Notify

on:
pull_request_target:
types: [labeled]
paths-ignore:
- compiler/**
- .github/workflows/compiler_**.yml

jobs:
notify:
if: ${{ github.event.label.name == 'React Core Team' }}
runs-on: ubuntu-latest
steps:
- name: Discord Webhook Action
uses: tsickert/discord-webhook@v6.0.0
with:
webhook-url: ${{ secrets.DISCORD_WEBHOOK_URL }}
embed-author-name: ${{ github.event.pull_request.user.login }}
embed-author-url: ${{ github.event.pull_request.user.html_url }}
embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }}
embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}'
embed-description: ${{ github.event.pull_request.body }}
embed-url: ${{ github.event.pull_request.html_url }}
35 changes: 0 additions & 35 deletions .github/workflows/shared_discord_notify.yml

This file was deleted.