From 55da99050c9781a6051d4c699b4fe4dcb8bfeea9 Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Tue, 30 Oct 2018 13:36:51 -0700 Subject: [PATCH] Nits --- packages/react-reconciler/src/ReactFiberScheduler.js | 4 ++-- .../react-test-renderer/src/ReactTestRendererScheduling.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiberScheduler.js b/packages/react-reconciler/src/ReactFiberScheduler.js index 6c2e4ca86d284..c43e61dc9a208 100644 --- a/packages/react-reconciler/src/ReactFiberScheduler.js +++ b/packages/react-reconciler/src/ReactFiberScheduler.js @@ -2125,12 +2125,12 @@ function performWork(minExpirationTime: ExpirationTime, isYieldy: boolean) { nextFlushedExpirationTime !== NoWork && (minExpirationTime === NoWork || minExpirationTime >= nextFlushedExpirationTime) && - (!didYield || currentRendererTime >= nextFlushedExpirationTime) + !(didYield && currentRendererTime < nextFlushedExpirationTime) ) { performWorkOnRoot( nextFlushedRoot, nextFlushedExpirationTime, - !(currentRendererTime >= nextFlushedExpirationTime), + currentRendererTime < nextFlushedExpirationTime, ); findHighestPriorityRoot(); recomputeCurrentRendererTime(); diff --git a/packages/react-test-renderer/src/ReactTestRendererScheduling.js b/packages/react-test-renderer/src/ReactTestRendererScheduling.js index b169989a96bc1..973bdc53504a0 100644 --- a/packages/react-test-renderer/src/ReactTestRendererScheduling.js +++ b/packages/react-test-renderer/src/ReactTestRendererScheduling.js @@ -37,7 +37,7 @@ export function shouldYield() { expectedNumberOfYields !== -1 && yieldedValues.length >= expectedNumberOfYields ) { - // We at least as many values as expected. Stop rendering. + // We yielded at least as many values as expected. Stop rendering. didStop = true; return true; }