Fix packager issue that happens as a result of incorrect node-haste callsites. #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allsites. Resolves issue @mkonicek mentioned here: facebook#6036 (comment)
|
cc @cpojer |
|
By analyzing the blame information on this pull request, we identified @martinbigio, @sebmarkbage and @cpojer to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@skevy updated the pull request. |
|
We should also lock node-haste to revisions as there are breaking changes between minor versions at the moment (react-natives specifies v2.0.0 but there are breaking changes in 2.2.0) or respect semver in node-haste. This will be problematic especially when there will be release versions that use node-haste from npm. |
|
@janicduplessis haste is fixed to ~2.0.0 in 89ea985. |
|
I guess this is covered in b41ad9f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue @mkonicek mentioned here: #6036 (comment)