Align order of params between calculateLayoutInternal and calculateLayoutImpl #47975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebook/yoga#1754 This was annoying me Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66510734
…youtImpl Summary: I've been working with callsites here and its annoying if you switch these that you need to move these params around too. Let's just make them the same order Changelog: [Internal] Differential Revision: D66519836
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66519836 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 27, 2024
…youtImpl Summary: X-link: facebook/yoga#1755 X-link: facebook/react-native#47975 I've been working with callsites here and its annoying if you switch these that you need to move these params around too. Let's just make them the same order Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66519836 fbshipit-source-id: 2e98e671270a053c6e62372e2003f1ca67774ec9
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 27, 2024
…youtImpl (#1755) Summary: Pull Request resolved: #1755 X-link: facebook/react-native#47975 I've been working with callsites here and its annoying if you switch these that you need to move these params around too. Let's just make them the same order Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66519836 fbshipit-source-id: 2e98e671270a053c6e62372e2003f1ca67774ec9
|
This pull request has been merged in 1d909ef. |
|
This pull request was successfully merged by @joevilches in 1d909ef When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've been working with callsites here and its annoying if you switch these that you need to move these params around too. Let's just make them the same order
Changelog: [Internal]
Differential Revision: D66519836