Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Android API < 23 in ReactDrawableHelper #39667

Closed
wants to merge 9 commits into from
Closed

Remove support for Android API < 23 in ReactDrawableHelper #39667

wants to merge 9 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 26, 2023

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
52a0e04 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 50f92bfce6254260a8ad58e79aeadbd618c28767
@analysis-bot
Copy link

analysis-bot commented Sep 26, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,912 -6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,654 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5be6f49
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
c4ce393 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 9817cea396dfa6e9101461c8cfb5e1367eb174c8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
b100830 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: a3e0facd051a4a8dc2393910e980b4f660526ac8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
757f427 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 09a5b0f59c7c8b84b6c1fcb9bae919869870d29b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
ba4d89d 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 6b781bc1034366658bda608926077c15e4bc0765
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
eac3ae6 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 43fe31b87c1e81de7f7d901aab3e9680d76d4be7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
36ee875 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 50aa2ddb6e7d4788072b2c0bb17dfcc8b852cf80
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 4abaee1

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
56f4102 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 725848a9281e7fd0e6d5045de71bd2109cf9b48c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
58d2b3a 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: f4ae1e5fcf6468af6e4c128190c5b13c7be9a0ab
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
2d04a43 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 97452458fc153efe0ec53e3623108db7be8508e2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 28, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
fb67ac3 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: ae3413ce6a72e58c80c9622099fd775f46fa6760
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 29, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
87cb6ba 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: ff9e0b5f7686b425995983caf35e2aa049aee7e3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 29, 2023
@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
dc22c43 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 7af11c008d9d1d38b4902eb84d3200113765ef9a
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in ReactTextShadowNode
006f76b 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextShadowNode

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextShadowNode

Differential Revision: D48545511

fbshipit-source-id: f23f78b45f31f8286f0412c42887b7efe9904dc6
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in ReactTextView
7f765e1 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextView

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextView

Differential Revision: D48545504

fbshipit-source-id: 8aca7fefe76e366181d5eb4bd507d5f5e032c295
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in TextAttributeProps
b784f2e 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextAttributeProps

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextAttributeProps

Differential Revision: D48545514

fbshipit-source-id: c1885dfb271f88509a00db78a09eaf9ae392c05c
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in TextLayoutManager
d8c6616 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Differential Revision: D48545502

fbshipit-source-id: 5ffe6402a711afd0a52fee1a08a85d15eb8db83c
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in TextLayoutManagerMapBuffer
7cf6864 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManagerMapBuffer

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManagerMapBuffer

Differential Revision: D48545518

fbshipit-source-id: f0be67faf2be565d7da55494aa74cfaab39a3199
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in ReactEditText
804bb9c 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText

Differential Revision: D48545507

fbshipit-source-id: 2820c40da037ebd5fb2a131845b2da6453f8e94f
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in ReactTextInputLocalData
3403b3a 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputLocalData

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputLocalData

Differential Revision: D48545510

fbshipit-source-id: 3f94ca5c966f83d3da52f08e63601935187c1877
@mdvacca @facebook-github-bot
Remove support for Android API < 23 in ReactTextInputShadowNode
ae5d82f 
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputShadowNode

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputShadowNode

Differential Revision: D48545503

fbshipit-source-id: 0ff53035d743624f84d98956e3cff01712d13b9f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545508

@mdvacca
Remove support for Android API < 23 in ReactDrawableHelper (facebook#…
4abaee1 
…39667)

Summary:
Pull Request resolved: facebook#39667

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper

Reviewed By: NickGerleman

Differential Revision: D48545508

fbshipit-source-id: 0aeccbed808f052ac16984cf9b620b94a98c9c8c
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 120aab2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdvacca @facebook-github-bot @analysis-bot