From 192eab0a6a988074a09e176a4e0882bf0de2c618 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Fri, 30 Jun 2023 03:20:44 -0700 Subject: [PATCH 1/2] Remove debug only code Differential Revision: D47127817 fbshipit-source-id: b7165610ce9d10d7646cbf843dc01c705bc10b6c --- .../Mounting/ComponentViews/Image/RCTImageComponentView.mm | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm index 65cea1460fc76e..472d83e45b12e0 100644 --- a/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm +++ b/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm @@ -109,9 +109,6 @@ - (void)_setStateAndResubscribeImageResponseObserver:(ImageShadowNode::ConcreteS // This will only become issue if we decouple life cycle of a // ShadowNode from ComponentView, which is not something we do now. imageRequest.cancel(); - imageRequest.cancel(); - imageRequest.cancel(); - imageRequest.cancel(); } } From d12f9c36998f1bd09a5ab6c4e2107a9cc77843c1 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Fri, 30 Jun 2023 03:21:16 -0700 Subject: [PATCH 2/2] Disable nstextstorage_caching in OSS (#38129) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38129 changelog: [iOS] Disable NSTextStorage caching in OSS A [bug was reported](https://github.com/facebook/react-native/issues/37944) for NSTextStorage caching. Even thought I fixed the bug in D47019250, I want to disable the feature in OSS until the fix is verified in Facebook app. My plan is to pick this commit for 0.72.1 and reenable NSTextStorage caching once the fix is validated. Reviewed By: NickGerleman Differential Revision: D47127912 fbshipit-source-id: 76d94e6e4c14a989765212faff57c78d91f176ee --- .../ReactCommon/react/config/ReactNativeConfig.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/react-native/ReactCommon/react/config/ReactNativeConfig.cpp b/packages/react-native/ReactCommon/react/config/ReactNativeConfig.cpp index 915c7737fb07d0..9a701c320e5f33 100644 --- a/packages/react-native/ReactCommon/react/config/ReactNativeConfig.cpp +++ b/packages/react-native/ReactCommon/react/config/ReactNativeConfig.cpp @@ -23,9 +23,6 @@ bool EmptyReactNativeConfig::getBool(const std::string ¶m) const { if (param == "react_fabric:enabled_layout_animations_ios") { return true; } - if (param == "react_fabric:enable_nstextstorage_caching") { - return true; - } return false; }