Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync with internal repository #37831

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Re-sync with internal repository #37831

merged 1 commit into from
Jun 12, 2023

Conversation

facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 12, 2023

Changelog: [Internal]
This diff is the one that actually passes the nightly dict of latest versions of nightlies for monorepo packages (done in D46450703) to set-rn-version.

This will then update package/react-native's package to update any dependencies/devDependencies to the specified nightly.

It will also update the template app's package to also use these nightly dependencies.

Changes:

  • Refactored set-rn-version's usage as a module
  • Update call-sites to use the module vs. spawning a process to execute the script -- overall, I'm not clear on why we're using shelljs for some things.
  • Include an additional param in setReactNativeVersion that is optional -- pass in list of specified versions of a dependencies you want to use in react-native and update its package with it.
  • Also use those dependency versions to update the template package.

The internal and external repositories are out of sync. This attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fh:direct-merge-enabled labels Jun 12, 2023
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 5a8b49d

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,747,834 +0
android hermes armeabi-v7a 8,060,436 +1
android hermes x86 9,239,441 +1
android hermes x86_64 9,089,238 +0
android jsc arm64-v8a 9,310,428 -1
android jsc armeabi-v7a 8,500,364 +1
android jsc x86 9,372,925 -1
android jsc x86_64 9,626,824 +0

Base commit: 03f70bf
Branch: main

@lunaleaps
Copy link
Contributor

There are some failures with the changes due to parameters passed to set-rn-version in ./scripts/run-ci-e2e-tests.js. Will fix these in a follow-up diff as we need to make sure main is synced

@lunaleaps lunaleaps merged commit 2eba6ab into main Jun 12, 2023
@lunaleaps lunaleaps deleted the fixup-T155554187-main branch June 12, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fh:direct-merge-enabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants