Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[virtualized-lists]: do not ship tests in npm package #36143

Closed
wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Feb 13, 2023

Summary:
Changelog: [Internal]

Currently, some __tests__ are included in react-native/virtualized-lists, added them to ignore list, so that we will remove it in the next publish

Reviewed By: christophpurrer

Differential Revision: D43159337

Summary:
Changelog: [Internal]

Currently, some `__tests__` are included in `react-native/virtualized-lists`, added them to ignore list, so that we will remove it in the next publish

Reviewed By: christophpurrer

Differential Revision: D43159337

fbshipit-source-id: 190c2b7c09c02156985cd05476cfdb8509f71850
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43159337

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,479,849 +0
android hermes armeabi-v7a 7,800,553 +0
android hermes x86 8,955,317 +0
android hermes x86_64 8,813,219 +0
android jsc arm64-v8a 6,697,160 +0
android jsc armeabi-v7a 7,488,676 +0
android jsc x86 9,221,349 +0
android jsc x86_64 6,922,213 +0

Base commit: f74c6e8
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 31ac1f8.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
)

Summary:
Pull Request resolved: facebook#36143

Changelog: [Internal]

Currently, some `__tests__` are included in `react-native/virtualized-lists`, added them to ignore list, so that we will remove it in the next publish

Reviewed By: christophpurrer

Differential Revision: D43159337

fbshipit-source-id: 27ed0adf85387a2e8ac902da57888f0b188b0b91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants