Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shelljs dependency and duplicated scripts in files #33915

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
We don't need to import shelljs as a dependency anymore,
plus we had a duplicated entry in the files array for package.json

Changelog:
[Internal] [Changed] - Remove shelljs dependency and duplicated scripts in files

Differential Revision: D36698750

Summary:
We don't need to import shelljs as a dependency anymore,
plus we had a duplicated entry in the files array for package.json

Changelog:
[Internal] [Changed] - Remove shelljs dependency and duplicated scripts in files

Differential Revision: D36698750

fbshipit-source-id: ba852352881692741ebccfbe543a7096bd0949a9
@cortinico cortinico requested a review from hramos as a code owner May 26, 2022 10:10
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 26, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36698750

@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against cf259ef

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0ef73f2
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,786,274 +0
android hermes armeabi-v7a 7,189,932 +0
android hermes x86 8,097,642 +0
android hermes x86_64 8,075,264 +0
android jsc arm64-v8a 9,654,822 +0
android jsc armeabi-v7a 8,427,323 +0
android jsc x86 9,606,998 +0
android jsc x86_64 10,201,554 +0

Base commit: 0ef73f2
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 833222f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 26, 2022
fortmarek pushed a commit that referenced this pull request May 30, 2022
Summary:
Pull Request resolved: #33915

We don't need to import shelljs as a dependency anymore,
plus we had a duplicated entry in the files array for package.json

Changelog:
[Internal] [Changed] - Remove shelljs dependency and duplicated scripts in files

Reviewed By: dmitryrykun

Differential Revision: D36698750

fbshipit-source-id: 94f449f2c3c5d73d0f9ffd29df6b26f5fd6ef129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants