-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Main][Windows] Working around Long paths limitation on Windows #33784
Conversation
…file paths and command lengths of ndk build commands Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
Co-authored-by: Aleš Pergl <[email protected]>
|
Base commit: 23a160e |
Base commit: 23a160e |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @mganandraj in 883a938. When will my fix make it into a release? | Upcoming Releases |
Thanks again for doing this amazing work and sending this over @mganandraj 🙏 |
* Update react-native monorepo * Upgrade to RN pods from 0.69.0-rc0 to rc1 * Revert Windows NDK 23 bump Ref: facebook/react-native#33784 * Update Xcode config diffs Ref: facebook/react-native@6efb517 (pbxproj) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: LeoTM <[email protected]>
* Update react-native monorepo * Upgrade to RN pods from 0.69.0-rc0 to rc1 * Revert Windows NDK 23 bump Ref: facebook/react-native#33784 * Update Xcode config diffs Ref: facebook/react-native@6efb517 (pbxproj) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: LeoTM <[email protected]>
Cherry picking #33707 to main branch
This change is extending the changes made by alespergl to reduce the file paths and command lengths of ndk build commands
Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression
This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
We are also reverting the ndk bump as ndk23 is crashing frequently when building RN with new arch. The reduced file paths lengths ensures the ndk bump is not required for relatively short application paths.
Summary
Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources
Changelog
Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources
[CATEGORY] [TYPE] - Message
Test Plan
Verified building on windows box