fix: jvm 11 error message from ReactPlugin.kt and react.gradle #33048

numandev1 · 2022-02-04T22:30:58Z

Summary

you can see discussion here: reactwg/react-native-releases#13 (comment)
we were getting this error message when we build Gradle with other than 11 JVM

> Task :react-native-gradle-plugin:compileJava FAILED
2 actionable tasks: 2 executed

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-gradle-plugin:compileJava'.
> invalid source release: 11

this solution is suggested by @mikehardy

after this PR, now the error is like this

**************************************************************************************************************



ERROR: requires JDK11 or higher.
Incompatible major version detected: '8'



**************************************************************************************************************

Changelog

[Android] [Fixed] - jvm 11 error message

Test Plan

install other than 11 java version and just run ./scripts/test-manual-e2e.sh this command at the root of RN repo than this error will appair invalid source release: 11

analysis-bot · 2022-02-04T23:02:11Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: cd79317
Branch: main

analysis-bot · 2022-02-04T23:08:43Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,120,912	+591
android	hermes	armeabi-v7a	7,720,886	-797
android	hermes	x86	8,490,376	-728
android	hermes	x86_64	8,442,339	-597
android	jsc	arm64-v8a	9,787,638	+518
android	jsc	armeabi-v7a	8,772,495	-876
android	jsc	x86	9,753,699	-812
android	jsc	x86_64	10,349,748	-682

Base commit: cd79317
Branch: main

packages/react-native-gradle-plugin/build.gradle.kts

mikehardy · 2022-02-06T17:04:17Z

I like this as a guard rail, the only thing I don't like is that it will require maintenance going forward, now there will be 3 spots to bump the JDK version in if the requirement moves. Isn't the real requirement that JDK is > 8? So perhaps there could be an integer parse and check for > 8 vs a fixed "11. That way JDK14 and 16 etc will work with no further work?

cortinico · 2022-02-06T17:56:02Z

I like this as a guard rail, the only thing I don't like is that it will require maintenance going forward, now there will be 3 spots to bump the JDK version in if the requirement moves. Isn't the real requirement that JDK is > 8? So perhaps there could be an integer parse and check for > 8 vs a fixed "11. That way JDK14 and 16 etc will work with no further work?

Agree. That's why having this inside react-native doctor was maybe a better approach.
On the other hand, if we want to add a quick warning on the Gradle side that will help people migrate to .68, that's probably the way to go

mikehardy

I like this a lot more! it won't just irritatingly break in the future now, but does protect against the JDK8 past.
The only thing I can think of now is that the error message is not really consistent with the test(s) anymore. Should probably say "... requires JDK11 or higher" ?

I do think this error message will help a lot of people though, even in the much much smaller developer community that is the AnkiDroid project (maybe 20 developers?) this helped a few people. Here in react-native for 0.68 I bet this helps hundreds, most of whom probably do not know about doctor yet

numandev1 · 2022-02-06T21:12:57Z

I like this as a guard rail, the only thing I don't like is that it will require maintenance going forward, now there will be 3 spots to bump the JDK version in if the requirement moves. Isn't the real requirement that JDK is > 8? So perhaps there could be an integer parse and check for > 8 vs a fixed "11. That way JDK14 and 16 etc will work with no further work?

Agree. That's why having this inside react-native doctor was maybe a better approach. On the other hand, if we want to add a quick warning on the Gradle side that will help people migrate to .68, that's probably the way to go

@cortinico Agree, I will also make another PR for doctor CLI.

@mikehardy you are right, I am done with the changes that you told

numandev1 · 2022-02-06T21:19:08Z

I like this a lot more! it won't just irritatingly break in the future now, but does protect against the JDK8 past. The only thing I can think of now is that the error message is not really consistent with the test(s) anymore. Should probably say "... requires JDK11 or higher" ?

I do think this error message will help a lot of people though, even in the much much smaller developer community that is the AnkiDroid project (maybe 20 developers?) this helped a few people. Here in react-native for 0.68 I bet this helps hundreds, most of whom probably do not know about doctor yet

@mikehardy Thanks, I have changed the error message with ERROR: requires JDK11 or higher.

mikehardy

Near as I can tell, it's a thing of beauty! 👍

cortinico · 2022-02-08T15:21:30Z

packages/react-native-gradle-plugin/build.gradle.kts

@@ -50,6 +52,19 @@ java {
    targetCompatibility = JavaVersion.VERSION_11


Please change those two to JavaVersion.VERSION_8 otherwise the build won't even start on JDK 8

as far as I know. users of old releases will use older versions of react-native-gradle-plugin. let me change it to JavaVersion.VERSION_1_8

@cortinico with JavaVersion.VERSION_1_8 i am getting this error

Build file '/Users/apple/Data/react-native/ReactAndroid/build.gradle' line: 9 * What went wrong: An exception occurred applying plugin request [id: 'com.android.library'] > Failed to apply plugin 'com.android.internal.library'. > Android Gradle plugin requires Java 11 to run. You are currently using Java 1.8. You can try some of the following options: - changing the IDE settings. - changing the JAVA_HOME environment variable. - changing `org.gradle.java.home` in `gradle.properties`.

Are you building with JDK 11 right?

@cortinico I am getting this error for java 1.8. with JDK 11 it is working well. should and replaceJavaVersion.VERSION_11 withJavaVersion.VERSION_1_8, I think, we should not replace it because there is no benefit according to me what do you say?

packages/react-native-gradle-plugin/build.gradle.kts

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt

facebook-github-bot · 2022-02-09T17:28:24Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-02-09T18:25:04Z

This pull request was successfully merged by @nomi9995 in 4e947ec.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: you can see discussion here: reactwg/react-native-releases#13 (comment) we were getting this error message when we build Gradle with other than 11 JVM ``` > Task :react-native-gradle-plugin:compileJava FAILED 2 actionable tasks: 2 executed FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':react-native-gradle-plugin:compileJava'. > invalid source release: 11 ``` this solution is suggested by mikehardy after this PR, now the error is like this ``` ************************************************************************************************************** ERROR: requires JDK11 or higher. Incompatible major version detected: '8' ************************************************************************************************************** ``` ## Changelog  [Android] [Fixed] - jvm 11 error message Pull Request resolved: #33048 Test Plan: install other than 11 java version and just run `./scripts/test-manual-e2e.sh` this command at the root of RN repo than this error will appair `invalid source release: 11` Reviewed By: ShikaSD Differential Revision: D34110990 Pulled By: cortinico fbshipit-source-id: c142a363c7cec0db65d5ab9da858fd25866c7c49

bozaigao · 2022-05-28T12:31:33Z

install idk 11;
AndroidStudio->file->ProjectStructure->click Gradle Settings->choose idk 11 ->sync;

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 4, 2022

react-native-bot added Bug Platform: Android Android applications. labels Feb 4, 2022

cortinico reviewed Feb 4, 2022

View reviewed changes

packages/react-native-gradle-plugin/build.gradle.kts Outdated Show resolved Hide resolved

numandev1 force-pushed the fix/jvm-11-error branch from 3c27c7f to 515f8be Compare February 5, 2022 10:36

numandev1 changed the title ~~fix: jvm 11 error message from react-native-gradle-plugin~~ fix: jvm 11 error message from build.gradle.kts, ReactPlugin.kt and react.gradle Feb 5, 2022

numandev1 force-pushed the fix/jvm-11-error branch 4 times, most recently from b92755c to eb32655 Compare February 5, 2022 20:42

numandev1 requested a review from cortinico February 5, 2022 21:18

numandev1 force-pushed the fix/jvm-11-error branch from eb32655 to 691c4f3 Compare February 6, 2022 20:48

mikehardy approved these changes Feb 6, 2022

View reviewed changes

numandev1 force-pushed the fix/jvm-11-error branch from 691c4f3 to 09afa5e Compare February 6, 2022 21:18

mikehardy approved these changes Feb 6, 2022

View reviewed changes

cortinico reviewed Feb 8, 2022

View reviewed changes

numandev1 force-pushed the fix/jvm-11-error branch from 09afa5e to f140b44 Compare February 8, 2022 17:00

numandev1 changed the title ~~fix: jvm 11 error message from build.gradle.kts, ReactPlugin.kt and react.gradle~~ fix: jvm 11 error message from ReactPlugin.kt and react.gradle Feb 8, 2022

fix: jvm 11 error message from ReactPlugin.kt and react.gradle

228ae8e

numandev1 force-pushed the fix/jvm-11-error branch from f140b44 to 228ae8e Compare February 8, 2022 17:07

facebook-github-bot closed this in 4e947ec Feb 9, 2022

react-native-bot added the Merged This PR has been merged. label Feb 9, 2022

numandev1 deleted the fix/jvm-11-error branch February 9, 2022 18:26

This was referenced Apr 21, 2022

[Snyk] Security upgrade react-native from 0.63.3 to 0.68.0 NOUIY/react-native-macos#28

Open

[Snyk] Upgrade react-native from 0.63.3 to 0.68.0 NOUIY/react-native-macos#32

Open

facebook locked as resolved and limited conversation to collaborators May 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: jvm 11 error message from ReactPlugin.kt and react.gradle #33048

fix: jvm 11 error message from ReactPlugin.kt and react.gradle #33048

numandev1 commented Feb 4, 2022 •

edited

Loading

analysis-bot commented Feb 4, 2022 •

edited

Loading

analysis-bot commented Feb 4, 2022 •

edited

Loading

mikehardy commented Feb 6, 2022

cortinico commented Feb 6, 2022

mikehardy left a comment

numandev1 commented Feb 6, 2022

numandev1 commented Feb 6, 2022

mikehardy left a comment

cortinico Feb 8, 2022

numandev1 Feb 8, 2022

numandev1 Feb 8, 2022

cortinico Feb 8, 2022

numandev1 Feb 8, 2022

facebook-github-bot commented Feb 9, 2022

react-native-bot commented Feb 9, 2022

bozaigao commented May 28, 2022

		@@ -50,6 +52,19 @@ java {
		targetCompatibility = JavaVersion.VERSION_11

fix: jvm 11 error message from ReactPlugin.kt and react.gradle #33048

fix: jvm 11 error message from ReactPlugin.kt and react.gradle #33048

Conversation

numandev1 commented Feb 4, 2022 • edited Loading

Summary

Changelog

Test Plan

analysis-bot commented Feb 4, 2022 • edited Loading

analysis-bot commented Feb 4, 2022 • edited Loading

mikehardy commented Feb 6, 2022

cortinico commented Feb 6, 2022

mikehardy left a comment

Choose a reason for hiding this comment

numandev1 commented Feb 6, 2022

numandev1 commented Feb 6, 2022

mikehardy left a comment

Choose a reason for hiding this comment

cortinico Feb 8, 2022

Choose a reason for hiding this comment

numandev1 Feb 8, 2022

Choose a reason for hiding this comment

numandev1 Feb 8, 2022

Choose a reason for hiding this comment

cortinico Feb 8, 2022

Choose a reason for hiding this comment

numandev1 Feb 8, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Feb 9, 2022

react-native-bot commented Feb 9, 2022

bozaigao commented May 28, 2022

numandev1 commented Feb 4, 2022 •

edited

Loading

analysis-bot commented Feb 4, 2022 •

edited

Loading

analysis-bot commented Feb 4, 2022 •

edited

Loading