Remove find-node.sh that cause PhaseScriptExecution.

[nitaking]

Summary

find-node.sh is th couse of many build errors. (Causes PhaseScriptExecution)

• /node_modules/react-native/scripts/../Libraries. No such file or directory. Command PhaseScriptExecution failed with a nonzero exit code #31228
• React Native 0.64.0, iOS application build issue. #31354
• Failed to launch a new app created with the command npx react-native init #31275
• iOS Build Error with react-native version - 0.64.0 #31259
• New project not working on IOS Xcode 12.4 react-native 0.64 (Command PhaseScriptExecution failed with a nonzero exit code) #31181
• React Native's initial project doesn't run on IOS. #31249
• Newly created react native project fails to run on iOS Simulator #31238

I think that the node path setting is not done by the library, but by the user.
If the react-native even complements the node's path setting, shouldn't it be complemented by the document?

What is the community's policy on this?
We are losing a lot of time to this meritless hacky code. This fix should be incorporated as a band-aid, even if it's not ideal.

Changelog

[iOS] [Fixed] - Remove find-node script.

Test Plan

[facebook-github-bot]

Hi @nitaking!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pull-bot]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 2c27863

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 96930fa

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,853,429	-782
android	hermes	armeabi-v7a	8,374,788	-903
android	hermes	x86	9,310,371	-856
android	hermes	x86_64	9,253,374	-714
android	jsc	arm64-v8a	10,584,458	-661
android	jsc	armeabi-v7a	10,088,937	-770
android	jsc	x86	10,602,897	-731
android	jsc	x86_64	11,186,169	-599

Base commit: 96930fa

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gnattu]

Let me add #31260 to this.

[nitaking]

Have identified a problem with the release build in this fix.

[nitaking]

@gnattu
Thanks.
The fix for #30781 succeeds in release build / debug build.
Can I incorporate the content from that PR into this PR?

[AyoubAtba]

I'm having this problem any solutions????

[leotm]

On new M1 Mac Mini after brew install node, sudo mkdir /usr/local/bin then sudo ln -s /opt/homebrew/bin/node /usr/local/bin/node got Xcode building for me, I gave current PR changes a shot first with no luck.

[nitaking]

This fix seems to have fixed the problem, so I'll close this PR.

d75683a

[rogeriomq]

On new M1 Mac Mini after brew install node, sudo mkdir /usr/local/bin then sudo ln -s /opt/homebrew/bin/node /usr/local/bin/node got Xcode building for me, I gave current PR changes a shot first with no luck.

I use ASDF and create link with sudo ln -s /Users/YOUR_USER/.asdf/shims/node /usr/local/bin/node. Solved!