[iOS] Remove snapshots below iOS12 #23889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhongwuzw in a205f64. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Mar 15, 2019
Summary: We already change iOS in CI to 12.1, so we can remove those unused snapshots. https://github.com/facebook/react-native/blob/master/scripts/.tests.env#L19 CC. hramos [iOS] [Fixed] - Remove snapshots below iOS12 Pull Request resolved: #23889 Differential Revision: D14477608 Pulled By: cpojer fbshipit-source-id: 1933de4fcfeecd12f03f3c7863e541b39be93b61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already change iOS in CI to 12.1, so we can remove those unused snapshots.
https://github.com/facebook/react-native/blob/master/scripts/.tests.env#L19
CC. @hramos
Changelog
[iOS] [Fixed] - Remove snapshots below iOS12
Test Plan
CI passes.