-[RCTBridge setUp] adding notification observer twice #999
Labels
Resolution: Locked
This issue was locked by the bot.
Comments
|
Thanks, it was already fixed internally, it should be out on the next sync. |
|
Removed on 5ce9fa4 |
facebook-github-bot
pushed a commit
that referenced
this issue
Nov 9, 2017
Summary: Nice addition of the recent Flow types for style props in 9c29ee1, however I think there are some slight issues in the definition. `type Styles = {[key: string]: Object}` makes sense, as it's referring to the set of named style groups a user creates a `StyleSheet` from, e.g. ```javascript const styles: StyleSheet = StyleSheet.create({ container: { height: 20 }, text: { color: '#999', fontSize: 12, }, }: Styles) ``` However `type StyleValue = {[key: string]: Object}` doesn't make sense. You actually want only the `Object` portion of that definition, presuming it's meant to be used like below: ```javascript type MyTextProps = { style: StyleProp, } <MyText style={{ color: '#999', fontSize: 12 }}>Hello</Text> ``` --- I've also added `void` to the `StyleValue`, as undefined seems to be handled fine, and can be a useful shorthand in JSX. --- And finally, I've allowed nesting of style prop arrays, by making StyleProp self-referencing, as RN seems to flatten those without issue. This can be important if you're passing in a style prop quite high up the component tree, and sticking it in an array with other styles at several points while it's passed down. N/A (These types aren't referenced anywhere else) [INTERNAL] [MINOR] [StyleSheet] - Refine Flow types Closes #16741 Reviewed By: frantic Differential Revision: D6278010 Pulled By: TheSavior fbshipit-source-id: 0170a233ab71d29f445786f5e695463f9730db3a
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this issue
Nov 19, 2017
Summary: Nice addition of the recent Flow types for style props in 9c29ee1, however I think there are some slight issues in the definition. `type Styles = {[key: string]: Object}` makes sense, as it's referring to the set of named style groups a user creates a `StyleSheet` from, e.g. ```javascript const styles: StyleSheet = StyleSheet.create({ container: { height: 20 }, text: { color: 'facebook#999', fontSize: 12, }, }: Styles) ``` However `type StyleValue = {[key: string]: Object}` doesn't make sense. You actually want only the `Object` portion of that definition, presuming it's meant to be used like below: ```javascript type MyTextProps = { style: StyleProp, } <MyText style={{ color: 'facebook#999', fontSize: 12 }}>Hello</Text> ``` --- I've also added `void` to the `StyleValue`, as undefined seems to be handled fine, and can be a useful shorthand in JSX. --- And finally, I've allowed nesting of style prop arrays, by making StyleProp self-referencing, as RN seems to flatten those without issue. This can be important if you're passing in a style prop quite high up the component tree, and sticking it in an array with other styles at several points while it's passed down. N/A (These types aren't referenced anywhere else) [INTERNAL] [MINOR] [StyleSheet] - Refine Flow types Closes facebook#16741 Reviewed By: frantic Differential Revision: D6278010 Pulled By: TheSavior fbshipit-source-id: 0170a233ab71d29f445786f5e695463f9730db3a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the -loadBundleAtURL:onComplete: block, -addObserver:selector:name:object: is called twice with the same arguments in the case when there is no error. Since the arguments are the same, there is no harm, but it's just wasted cycles.
The text was updated successfully, but these errors were encountered: