Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RCTImageLoader][0.33 & 0.34] Crash #9882

Closed
pietropizzi opened this issue Sep 13, 2016 · 14 comments
Closed

[RCTImageLoader][0.33 & 0.34] Crash #9882

pietropizzi opened this issue Sep 13, 2016 · 14 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@pietropizzi
Copy link

Issue Description

When scrolling a listview with items that have image views the app will eventually crash in

RCTImageLoader.m#L383 (Crashlytics Crashreport)

or in

RCTImageLoader.m#L502 (Crashlytics Crashreport)

Steps to Reproduce / Code Snippets

In our app just scroll a longer list that has remote images, eventually it will crash.

Expected Results

The app should not crash.

Additional Information

  • React Native version: 0.33.0
  • Platform: iOS
  • Operating System: macOS
@pietropizzi
Copy link
Author

This seems to have been introduced in this commit going into RN 0.33: 1418828 at least it touches exactly the line that is crashing

@pietropizzi pietropizzi changed the title [RCTImageLoad][0.33] Crash [RCTImageLoader][0.33] Crash Sep 13, 2016
@max-mykhailenko max-mykhailenko mentioned this issue Sep 13, 2016
Closed
@npomfret
Copy link
Contributor

I'm getting lots of crashes also, all related I think:

http://crashes.to/s/96034f860eb
http://crashes.to/s/e5f0b80d061
http://crashes.to/s/40184834c7e

@raspasov
Copy link

Hey guys, we have a similar crash, affecting consistently a number of our users - I think related to the problems people have mentioned so far.

http://crashes.to/s/518580ef4b9 (line 383)
http://crashes.to/s/8ebd91bfbf8 (line 385)

Both crashes on React Native 0.33.

@littlesome
Copy link

same crash issue
need your help, @javache

@littlesome littlesome mentioned this issue Sep 20, 2016
Closed
@bsiddiqui
Copy link

We were able to prevent this crash by prefetching images

@javache
Copy link
Member

javache commented Sep 21, 2016

We have seen these crashes disappear in v34.

@raspasov
Copy link

@javache Great! I'll test it out and report back.

@jerson
Copy link

jerson commented Sep 23, 2016

Same on 34 RC :(

http://crashes.to/s/7c31b33b411

@pfeiffer
Copy link
Contributor

Seeing this as well - also present in 0.32.

@pietropizzi pietropizzi changed the title [RCTImageLoader][0.33] Crash [RCTImageLoader][0.33 & 0.34] Crash Sep 26, 2016
@pietropizzi
Copy link
Author

@javache I can confirm the same severity in 0.34 as was in 0.33. In our app you just have to scroll 2 - 3 pages worth and it crashes. Very reproducible.

@pfeiffer pfeiffer mentioned this issue Sep 28, 2016
Closed
@chandlervdw
Copy link

This has prevented us from upgrading from 0.32. :(

@chiplay
Copy link

chiplay commented Sep 28, 2016

Same issue here, definitely excited to get this fixed and make the upgrade!

facebook-github-bot pushed a commit that referenced this issue Sep 28, 2016
@pfeiffer
Use strong reference in RCTImageLoader
b2dac83 
Summary:
This PR is related to the multitude of crashes (#10016, #9751, #9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR #9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes #10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
cmcewen pushed a commit to cmcewen/react-native that referenced this issue Sep 28, 2016
@pfeiffer @cmcewen
Use strong reference in RCTImageLoader
936bbb9 
Summary:
This PR is related to the multitude of crashes (facebook#10016, facebook#9751, facebook#9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR facebook#9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes facebook#10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
@jerson
Copy link

jerson commented Sep 29, 2016

@chiplay for me Strong reference don't solve this problem :/

http://crashes.to/s/c55a4e38ab1

@ide
Copy link
Contributor

ide commented Sep 29, 2016

Closing this issue since #9849 is tracking the same bug -- subscribe to that one.

@ide ide closed this as completed Sep 29, 2016
mikelambert pushed a commit to mikelambert/react-native that referenced this issue Sep 29, 2016
@pfeiffer @mikelambert
Use strong reference in RCTImageLoader
25ce67e 
Summary:
This PR is related to the multitude of crashes (facebook#10016, facebook#9751, facebook#9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR facebook#9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes facebook#10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
gre pushed a commit to gre/react-native that referenced this issue Oct 10, 2016
@pfeiffer @gre
Use strong reference in RCTImageLoader
9b19041 
Summary:
This PR is related to the multitude of crashes (facebook#10016, facebook#9751, facebook#9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR facebook#9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes facebook#10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
grabbou pushed a commit that referenced this issue Oct 10, 2016
@pfeiffer @grabbou
Use strong reference in RCTImageLoader
cf906cc 
Summary:
This PR is related to the multitude of crashes (#10016, #9751, #9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR #9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes #10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
pfeiffer added a commit to pfeiffer/react-native that referenced this issue Oct 12, 2016
@pfeiffer
Use strong reference in RCTImageLoader
a6c06ef 
Summary:
This PR is related to the multitude of crashes (facebook#10016, facebook#9751, facebook#9882).

From my understanding, we should be using a strong reference when calling `decodeImageData` or we could be calling the method on a deallocated instance.

PR facebook#9751 have mitigated this by adding a fail-safe, but I think the culprint is the weak reference, which this PR fixes.

Tested on iOS only, since it doesn't touch Android.
Closes facebook#10147

Differential Revision: D3938763

fbshipit-source-id: 7389d4ae7a98926014401a1fe0cbbdcdd5ee6a01
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests